Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARITH] Enhance CanProve to handle symbolic bound #14523

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Apr 6, 2023

This PR enhances CanProve to handle symbolic bound.
Such analysis is essential to eliminate predicates in
dynamic shape workloads.

We also the int set analysis singlepoint check to avoid recursion
and improve the overall analysis speed.

Added CanProveSinglePoint to serve previous stronger checks.

The new CanProve comes with additinal strength argument
that can only be used in top-level setting with stronger analysis.

Added comment for future implementation efficiency.

Testcases are added to cover the cases.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Apr 6, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tqchen
Copy link
Member Author

tqchen commented Apr 7, 2023

cc @vinx13 as this relates to a change introduced in #11234,

@tqchen tqchen force-pushed the arith branch 3 times, most recently from 773030c to a7eab35 Compare April 8, 2023 01:14
@tqchen tqchen changed the title [ARITH] Enhance TryCompare to handle symbolic bound [ARITH] Enhance CanProve to handle symbolic bound Apr 8, 2023
This PR enhances CanProve to handle symbolic bound.
Such analysis is essential to eliminate predicates in
dynamic shape workloads.

We also the int set analysis singlepoint check to avoid recursion
and improve the overall analysis speed.

Added CanProveSinglePoint to serve previous stronger checks.

The new CanProve comes with additinal strength argument
that can only be used in top-level setting with stronger analysis.

Added comment for future implementation efficiency.

Testcases are added to cover the cases.
@junrushao junrushao merged commit a84a2cb into apache:main Apr 8, 2023
jinhongyii pushed a commit to jinhongyii/tvm that referenced this pull request Apr 10, 2023
…e#14523) (apache#175)

This PR enhances CanProve to handle symbolic bound. Such analysis is
essential to eliminate predicates in dynamic shape workloads.

We also the int set analysis singlepoint check to avoid recursion and
improve the overall analysis speed.

Added CanProveSinglePoint to serve previous stronger checks.

The new CanProve comes with additinal strength argument that can only be
used in top-level setting with stronger analysis.

Added comment for future implementation efficiency.

Testcases are added to cover the cases.

Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com>
tqchen added a commit to tqchen/tvm that referenced this pull request Apr 11, 2023
…e#14523) (apache#175)

This PR enhances CanProve to handle symbolic bound. Such analysis is
essential to eliminate predicates in dynamic shape workloads.

We also the int set analysis singlepoint check to avoid recursion and
improve the overall analysis speed.

Added CanProveSinglePoint to serve previous stronger checks.

The new CanProve comes with additinal strength argument that can only be
used in top-level setting with stronger analysis.

Added comment for future implementation efficiency.

Testcases are added to cover the cases.

Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com>
@tqchen
Copy link
Member Author

tqchen commented Apr 11, 2023

cc @Lunderberg @wrongtest-intellif for awareness of the related features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants